[FFmpeg-devel] [PATCH] Add libavcodec/dpcm.c codec long_names
Thu May 15 13:30:19 CEST 2008
On Thu, May 15, 2008 at 09:23:31AM +0200, Stefano Sabatini wrote:
> On date Wednesday 2008-05-14 19:09:56 -0700, Mike Melanson encoded:
> > Stefano Sabatini wrote:
> > > Hi all, as in subject.
> > >
> > > By the way, we named in roqaudioenc.c roq_audio_encoder with id
> > > CODEC_ID_ROQ_DPCM like "Id RoQ audio", should we change that to "Id
> > > RoQ DPCM" for consistency with this patch (or the other way round)?
> > Come to think of it, 'id' should be spelling with a lowercase 'i'. And
> > DPCM is more explanatory than audio, yes.
> OK, so expect another one to change all the instances of Id in id (also
> we should update the Multimedia Wiki accordingly).
Go right ahead. In the meantime, I have applied your patch.
> --- libavcodec/dpcm.c (revision 13155)
> +++ libavcodec/dpcm.c (working copy)
> @@ -304,9 +304,10 @@
> -DPCM_DECODER(CODEC_ID_ROQ_DPCM, roq_dpcm);
> +DPCM_DECODER(CODEC_ID_ROQ_DPCM, roq_dpcm, "id RoQ DPCM");
Note that this does not get printed, the declaration in roqaudioenc.c
seems to take precedence. But you said you wanted to update this anyway
More information about the ffmpeg-devel