[FFmpeg-devel] [PATCH] Common ACELP code & G.729 [3/7] - vectors operations

Vladimir Voroshilov voroshil
Sat May 17 17:25:05 CEST 2008


2008/5/14 Michael Niedermayer <michaelni at gmx.at>:
> On Wed, May 14, 2008 at 12:08:01AM +0700, Vladimir Voroshilov wrote:
>> 2008/5/12 Michael Niedermayer <michaelni at gmx.at>:
>> > On Sun, May 11, 2008 at 09:46:04PM +0700, Vladimir Voroshilov wrote:
>> >  > 2008/5/9 Vladimir Voroshilov <voroshil at gmail.com>:

[...]

>> >  > > Hm. I hope, this version is better..
>> >
>> >  there are still 2 seperate functions and now there are even wraper functions
>> >  this is not better IMHO.
>> >  see my example above, is there a problem with it?
>>
>> Already implemented yours routine.
>> Now i should remove those wrappers,
>> make common routine non-static and
>> use it in main loop, right?
>
> yes
>
>
>>
>> >  > +/**
>> >  > + * low-pass FIR (Finite Impulse Response) filter coefficients
>> >  > + *
>> >  > + *   A similar filter is named b30 in G.729.
>> >  > + *

[...]

>> >  Maybe the generic interpolation should be in a seperate file.
>>
>> Move it back to acelp_filters together with corresponding lookup tables?
>
> yes, it seems o fit better there

Attached patch is version with  removed interpolation filter.

-- 
Regards,
Vladimir Voroshilov mailto:voroshil at gmail.com
JID: voroshil at gmail.com, voroshil at jabber.ru
ICQ: 95587719
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 03_acelp_vectors51.diff
Type: text/x-diff
Size: 9581 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080517/05d107ab/attachment.diff>



More information about the ffmpeg-devel mailing list