[FFmpeg-devel] [PATCH] Common ACELP code & G.729 [6/7] - G.729 postfilter

The Wanderer inverseparadox
Sat May 17 18:50:34 CEST 2008


Vladimir Voroshilov wrote:

> 2008/5/15 Diego Biurrun <diego at biurrun.de>:
>> On Sun, May 11, 2008 at 10:01:41PM +0700, Vladimir Voroshilov wrote:
>>>
> 
> [...]
> 
>>> + * At second stage long-term postfilter searches best fractional pitch
>>> + * delay with 1/(1+ANALYZED_FRAC_DELAYS) resolution around found at first stage
>>> + * integer pitch delay.
>>
>> Ummm, "around" what?
> 
> around _found_at_first_stage_integer_pitch_delay_.
> How to spell this correctly?

It's already spelled correctly, it just isn't phrased correctly.

If I understand this sentence correctly, I would write it as something
like

==
At the second stage, the long-term postfilter searches for the best 
fractional pitch delay which has a resolution of 
1/(1+ANALYZED_FRAC_DELAYS) and is near the integer pitch delay which was 
found in the first stage.
==

That's not entirely ideal, and could still be confusing, but I think
it's probably much less so than the previous form.

-- 
       The Wanderer

Warning: Simply because I argue an issue does not mean I agree with any
side of it.

Secrecy is the beginning of tyranny.




More information about the ffmpeg-devel mailing list