[FFmpeg-devel] [PATCH] Fix leak in mov.c

[Albert Astals Cid]

El Wednesday 21 May 2008 00:59:12 Baptiste Coudurier va escriure:
> Hi,
>
> Albert Astals Cid wrote:
> > [...]
> >
> >      atom.type = MKTAG('m','o','o','v');
> >      atom.offset = 0;
> >      atom.size = moov_len;
> > @@ -1603,6 +1603,10 @@
> >      av_log(c->fc, AV_LOG_ERROR, "this file requires zlib support
> > compiled in\n"); return -1;
> >  #endif
> > +error:
> > +    av_free(moov_data);
> > +    av_free(cmov_data);
> > +    return -1;
> >  }
>
> Code must be under #ifdef CONFIG_ZLIB, otherwise it is just dead code.

Right.

Albert

-------------- next part --------------
A non-text attachment was scrubbed...
Name: mov.c.leak_patch
Type: text/x-diff
Size: 826 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080521/4cd9fd9b/attachment.diff>