[FFmpeg-devel] [PATCH] Add versioning information to dlls

[Jeremy Kolb]

Ramiro Polla wrote:
> Jeremy Kolb wrote:
>   
>> This patch adds support for generating .rc files and then linking them 
>> with the dlls created by ffmpeg.  This information can be used to 
>> identify the product version by the user and is also available to 
>> installer programs for ease of updating etc.
>>     
>
> Diego, Mans, ping?
>
> [...]
>   
>> +dllinfo_generate() {
>> +    name=$1
>> +    description=$2
>> +    version=$3
>> +    major=${version%%.*}
>> +    version_commas=`echo $version | tr . ,`,0
>> +    dllname=`echo $name | sed s/lib//`
>> +
>> +    cat <<EOF >$TMPRC
>> +#include <WinVer.h>
>> +#include "version.h"
>> +VS_VERSION_INFO VERSIONINFO
>> + FILEVERSION $version_commas
>> + PRODUCTVERSION $version_commas
>> + FILEFLAGSMASK 0x17L
>> + FILEFLAGS 0x0L
>> + FILEOS VOS__WINDOWS32
>> + FILETYPE VFT_DLL
>> + FILESUBTYPE 0x0L
>> +BEGIN
>> +    BLOCK "StringFileInfo"
>> +    BEGIN
>> +        BLOCK "040904b0"
>> +        BEGIN
>> +            VALUE "Comments",            "FFmpeg is distributed under the terms "
>> +                                         "of the GNU $license.\r\n"
>>     
>
> "FFmpeg is distributed under the terms of the GNU unredistributable."
>
> That doesn't look right =)
>
>   
Oops.  Try this next one instead.
>> +                                         "Source code is available at "
>> +                                         "http://ffmpeg.mplayerhq.hu"
>>     
>
> I was hoping Diego would comment on this, but I think http://ffmpeg.org 
> or something similar is preferred.
>
>   
>> +            VALUE "CompanyName",         "FFmpeg"
>> +            VALUE "FileDescription",     "$description"
>> +            VALUE "FileVersion",         "$version"
>> +            VALUE "InternalName",        "$name"
>> +            VALUE "LegalCopyright",      "(C) 2000-2006 Fabrice Bellard, et al."
>>     
>
> 2006?
>
>   
Fixed.
>> +            VALUE "LegalTrademarks",     "FFmpeg"
>> +            VALUE "OriginalFilename",    "$dllname-$major.dll"
>>     
>
> Could you check if there's no way to get the correct lib name instead of 
> trying to recreate the name? If this is ever used for cygwin, it has the 
> cyg prefix in it...
>
>   

I'm not sure how to accomplish that.  If anyone has any ideas...

Here's the new version.


Jeremy
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: add_dllinfo.patch
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080521/5d3338e3/attachment.txt>