[FFmpeg-devel] [PATCH] AAC decoder

Robert Swain robert.swain
Thu May 22 10:49:00 CEST 2008

2008/5/22 Michael Niedermayer <michaelni at gmx.at>:
> On Wed, May 21, 2008 at 03:34:26PM +0100, Robert Swain wrote:
>> 2008/4/2 Michael Niedermayer <michaelni at gmx.at>:
>> > useless cast and cc_scale is useless too
>> I have two possibilities for this:
>> 20080521-remove_cc_scale-scale_idx.diff
>> 20080521-remove_cc_scale-scale.diff
>> The latter avoids a division within the loops at the cost of an
>> additional pow() call. I didn't know which would be preferred (though
>> I would lean toward the latter at a guess) so I'm submitting both for
>> review. :)
> ok

Second solution applied.

>> >> +static void tns_filter_tool(AACContext * ac, int decode, sce_struct * sce, float * coef) {
>> >
>> > bad name ...
>> The spec calls this function tns_decode_frame. Is that acceptable or
>> if not, do you have any hints? TNS == Temporal Noise Shaping.
> Ill think about it in the next iteration of the review, its hard to
> suggest something without seeing the whole code ...

OK. I will try to address the other major comments and leave this and
maybe some other more minor things I don't quite know how to 'fix'
until I submit another full patch.

Thanks for reviewing!

More information about the ffmpeg-devel mailing list