[FFmpeg-devel] [PATCH] parse audio in ogm
Mon May 26 02:37:09 CEST 2008
Justin Ruggles <justinruggles at bellsouth.net> writes:
> M?ns Rullg?rd wrote:
>> Justin Ruggles <justinruggles at bellsouth.net> writes:
>>> This fixes Issue165. It seems that any type of audio that can be
>>> wrapped in wav can be wrapped in ogm, and that it does not necessarily
>>> have exactly one frame per packet.
>> Hardly surprising.
>>> Index: libavformat/oggparseogm.c
>>> --- libavformat/oggparseogm.c (revision 13380)
>>> +++ libavformat/oggparseogm.c (working copy)
>>> @@ -68,6 +68,7 @@
>>> acid = 0;
>>> cid = strtol(acid, NULL, 16);
>>> st->codec->codec_id = codec_get_id(codec_wav_tags, cid);
>>> + st->need_parsing = AVSTREAM_PARSE_FULL;
>>> p += 4; /* useless size field */
>> Am I correct to assume that there is no way to tell when the parsing
>> is actually needed? If the answer is yes, the patch is OK. Either
>> way, do you have a sample?
> I don't think there is a way to know. From what I can tell, most other
> demuxers either set it unconditionally or only for a list of explicitly
> specified codecs.
Well, then go ahead and apply the patch.
mans at mansr.com
More information about the ffmpeg-devel