[FFmpeg-devel] [PATCH] qt_faststart: use proper PRI types and more helpful message

Reimar Döffinger Reimar.Doeffinger
Tue May 27 18:37:47 CEST 2008

On Mon, May 26, 2008 at 06:19:36PM -0700, Mike Melanson wrote:
> Baptiste Coudurier wrote:
> > Hi Reimar,
> > 
> > Reimar D?ffinger wrote:
> >> Hello,
> >> attached patch adds the encountered atom to the "encountered non-QT
> >> top-level atom" message which is very useful for debugging and
> >> it changes the llX printf type to the correct "PRIX64" (to be applied in
> >> two parts obviously).
> >> Comments/objections?
> > 
> > IMHO it would be better to print atom in a human readable way.
> I vote for both. Print out the number and, in parentheses, the 
> characters, if they fall in the ASCII range (not always true if the file 
> is corrupted).

Obviously that would be better, but I consider it too much effort for
the little advantage it brings. Printing _something_ makes the
difference of being able to debug or not at all (unless you can get
access to the file that creates problems), printing as ASCII is just a
convenience function.

More information about the ffmpeg-devel mailing list