[FFmpeg-devel] [PATCH] fix $(PREFIX) references in pkgconfig files

Diego Biurrun diego
Thu May 29 11:57:24 CEST 2008


On Thu, May 29, 2008 at 05:25:25AM +0300, Anssi Hannula wrote:
> Diego Biurrun wrote:
> > On Sun, May 18, 2008 at 03:08:43PM +0300, Anssi Hannula wrote:
> >> pkgconfig-private-requires.patch:
> >> When the shared libraries are built, make the requires Requires.private,
> >> as the libav* user does not need to link against those (i.e. the same we
> >> did for Libs earlier).
> > 
> > Ummmm...
> 
> If you want to know more, here's pkg-config's maintainer's commentary on
> Requires.private:
> http://err.no/personal/blog/tech/2008-03-25-18-07_pkg-config,_sonames_and_Requires.private.html
> 
> >> --- ffmpeg.orig/configure
> >> +++ ffmpeg/configure
> >> @@ -2148,7 +2148,7 @@ includedir=$incdir
> >>  Name: $name
> >>  Description: $comment
> >>  Version: $version
> >> -Requires: $requires
> >> +Requires$(enabled shared && echo ".private"): $requires
> > 
> > No, this is too ugly.  Instead you could add a Requires.private line and
> > add $requires where appropriate.
> 
> You mean like the Libs one? Attached.

Yes, like this; applied.

Diego




More information about the ffmpeg-devel mailing list