[FFmpeg-devel] [PATCH] remove unnecessary header files
Thu May 29 17:13:11 CEST 2008
On Thu, May 29, 2008 at 07:50:18AM -0700, Erik Hovland wrote:
> On Thu, May 29, 2008 at 03:38:39PM +0200, Diego Biurrun wrote:
> > > -#include "ffserver.h"
> > Wrong.
> > > --- a/libavutil/tree.c
> > > +++ b/libavutil/tree.c
> > > @@ -19,7 +19,6 @@
> > >
> > > #include "common.h"
> > > -#include "log.h"
> > Wrong.
> > I haven't reviewed this completely, but I do not trust the rest of the
> > changes much. I applied the correct changes that I noted above.
> Oh ye of little faith :)
Ummm, just look at tree.c, it uses av_log all over the place, which is
declared in log.h ...
After looking again, it seems I was wrong about ffserver.c/ffserver.h.
I will apply that change as well.
> But no sweat. I don't think they are necessary because the files that
> include them do not use any code within them. But if you think they are
> necessary, who am I to judge.
Well, I found those two errors above after a quick search, those other
files would take more time to check. Thus I'm not feeling confident
enough to apply your patch right now.
More information about the ffmpeg-devel