[FFmpeg-devel] [PATCH] Make long_names definition conditional depending on CONFIG_SMALL

[Michael Niedermayer]

On Thu, May 29, 2008 at 04:56:54PM +0200, Reimar D?ffinger wrote:
> On Thu, May 29, 2008 at 04:50:54PM +0200, Stefano Sabatini wrote:
> > -    const char *long_name;                  ///< descriptive name for the codec, meant to be more human readable than \p name
> > +    /**
> > +     * descriptive name for the codec, meant to be more human readable than \p name
> > +     * You \e should use the CODEC_REGISTER_LONG_NAME() macro to define it.
> > +     */
> > +    const char *long_name;
> >      const int *supported_samplerates;       ///< array of supported audio samplerates, or NULL if unknown, array is terminated by 0
> >  } AVCodec;
> >  
> > +#ifdef CONFIG_SMALL
> > +#define REGISTER_CODEC_LONG_NAME(long_name_) \
> > +    .long_name = NULL
> > +#else
> > +#define REGISTER_CODEC_LONG_NAME(long_name_) \
> > +    .long_name = long_name_
> > +#endif
> 
> Macro name does not match above description. Also I think the "REGISTER"
> in the name does not make sense, it does not register anything.
> I would find e.g. FF_CODEC_LONG_NAME better.

what about
#ifdef CONFIG_SMALL
#   define NULL_IF_CONFIG_SMALL(x) NULL
#else
#   define NULL_IF_CONFIG_SMALL(x) x
#endif


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is dangerous to be right in matters on which the established authorities
are wrong. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080529/bfa96f23/attachment.pgp>