[FFmpeg-devel] Coverity

Reimar Döffinger Reimar.Doeffinger
Thu May 29 18:00:34 CEST 2008

On Thu, May 29, 2008 at 03:42:11AM +0200, Michael Niedermayer wrote:
> As everyone should have already noticed (from svn log) we are currently
> trying to fix all the coverity warnings (also called "defects").
> 24 are left, are the maintainers of the respective files going to deal with
> them or should i try?

I had a bit of a look at the other uninspected cases. I did not make any
changes in the web interface though.

> FORWARD_NULL 	sdp_read_header 		libavformat/rtsp.c

Probably not wrong, but IMO at least a case of bad/obfuscated coding.

> RESOURCE_LEAK 	mpegts_write_header 		libavformat/mpegtsenc.c

At least the analysis is completely off. I also think there probably is
no resource leak at all here, but I did not check in detail.

> RESOURCE_LEAK 	matroska_add_stream 		libavformat/matroskadec.c

I think this issue might actually cause crashes and not just a leak.
Without knowing the code well enough, the whole function looks a bit fishy
to me.

> RESOURCE_LEAK 	sdt_cb 				libavformat/mpegts.c

The CID49 one I think is fixed in SVN.

> USE_AFTER_FREE 	ebml_read_header 		libavformat/matroskadec.c

Seems completely bogus to me. I have seen the tool mess up completely a
few times in such cases before.

> NEGATIVE_RETURNS matroska_read_header 		libavformat/matroskadec.c

Seems already fixed in SVN.

Reimar D?ffinger

More information about the ffmpeg-devel mailing list