[FFmpeg-devel] [PATCH] Function to parse Dirac sequence header

[David Conrad]

On Nov 6, 2008, at 5:15 AM, Diego Biurrun wrote:

> On Wed, Nov 05, 2008 at 11:22:01PM -0500, David Conrad wrote:
>>
>> This will be useful for both the dirac parser and ogg demuxer (and
>> future native dirac decoder of course.)
>> Adapted from the soc repository.
>>
>> --- /dev/null
>> +++ b/libavcodec/dirac.c
>> @@ -0,0 +1,259 @@
>> +    /* framerate */
>> +    if (get_bits1(gb)) {
>> +        source->frame_rate_index = svq3_get_ue_golomb(gb);
>
> This function is used in svq3.c, rv30.c, rv40.c and now dirac.c.
> Clearly, the svq3_ prefix is misleading and it should be renamed.
>
> Does anybody have a suggestion for a better name?

Going by what Kostya said, "get_ue_elias()"?

>> --- /dev/null
>> +++ b/libavcodec/dirac.h
>> @@ -0,0 +1,110 @@
>> +
>> +typedef struct {
>> +
>> +typedef struct
>> +{
>
> inconsistent brace placement

Fixed. Also added version and profile info to the struct.

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: dirac_sequence.txt
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20081107/381fa6fa/attachment.txt>
-------------- next part --------------