[FFmpeg-devel] usage of Requires.private in *.pc files

[Måns Rullgård]

Reinhard Tartler <siretart at tauware.de> writes:

> M?ns Rullg?rd <mans at mansr.com> writes:
>
>>> In detail: I need to know how and in what way libavcodec exposes
>>> implementation details (structures, enums, etc) of libraw1394, dirac,
>>> theora, vorbisenc. I believe avcodec does not at all, but I want to be
>>> sure.
>>
>> It does not.
>
> In that case I propose this patch:
>
> ===================================================================
> --- configure   (Revision 15797)
> +++ configure   (Arbeitskopie)
> @@ -2360,11 +2360,11 @@
>  Name: $name
>  Description: $comment
>  Version: $version
> -Requires: $(disabled shared && echo $requires)
> -Requires.private: $(enabled shared && echo $requires)
> +Requires:
> +Requires.private:

Are those empty declarations really needed?

>  Conflicts:
>  Libs: -L\${libdir} -l${shortname} $(disabled shared && echo $libs)
> -Libs.private: $(enabled shared && echo $libs)
> +Libs.private: $(enabled shared && echo $libs) $(enabled shared && echo $requires) 

That can be simplified.

>  Cflags: -I\${includedir}
>  EOF
>  cat <<EOF > $name/$name-uninstalled.pc

I will not approve any change to the .pc files until at least two
other people who actually use them on different distros have confirmed
that the change doesn't break anything.

>>  I can't see how it could, nor how it could matter if it did.
>
> this does happen e.g.in the gnome world, where types like structs or
> enums are used inside "own" structs, and exposed to applications.

The FFmpeg developers are full-sized men.  We don't do such things.

-- 
M?ns Rullg?rd
mans at mansr.com