[FFmpeg-devel] [PATCH] RDT/Realmedia patches #2

Michael Niedermayer michaelni
Fri Nov 14 18:25:55 CET 2008


On Fri, Nov 14, 2008 at 12:19:50PM -0500, Ronald S. Bultje wrote:
> Hi,
> 
> On Fri, Nov 14, 2008 at 11:52 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
> > On Fri, Nov 14, 2008 at 11:12:29AM -0500, Ronald S. Bultje wrote:
> >> Index: ffmpeg-svn/libavformat/rdt.c
> >> ===================================================================
> >> --- ffmpeg-svn.orig/libavformat/rdt.c 2008-11-11 15:30:12.000000000 -0500
> >> +++ ffmpeg-svn/libavformat/rdt.c      2008-11-14 11:05:33.000000000 -0500
> >> @@ -184,6 +184,47 @@
> >>      }
> >>      if (len < 10)
> >>          return -1;
> >> +    /**
> >> +     * Layout of the header (in bits):
> >> +     * 1:  Flag indicating whether this header includes a length field;
> >> +           this can be used to concatenate multiple RDT packets in a
> >> +           single UDP/TCP data frame and is used to precede RDT data
> >> +           by stream status packets
> >
> >> +     * 1:  Flag indicating whether this header includes a "reliable
> >> +           sequence number" (need_reliable); these are apparently
> >> +           sequence numbers of data packets alone. For data packets, this
> >> +           flag is always set, according to the Real documentation [1]
> >
> >> +     * 5:  ID of a set of streams of identical content, possibly with
> >> +     *     codecs or bitrates
> >
> > is this sentance supposed to make sense?
> > also why are the * a the begin randomly ommited?
> 
> Sorry, my mistake, fixed (both).
> 
> >> +     * 1:  Flag set for certain streams deemed less tolerable for packet
> >> +           loss
> >
> > are you sure its stream and not packet?
> 
> I know it sounds stupid, but that's what the Real documentation says
> (see references at the bottom of the patch).
> 
> >> +     * if (set_id == 0x1F) {
> >
> > undefined variable
> >
> >
> >> +     *     16: extended set_ID
> >> +     * }
> >
> >> +     * if (need_reliable_fag) {
> >
> > undefined variable
> >
> >
> >> +     *     16: Reliable sequence number
> >> +     * }
> >
> >> +     * if (stream_id == 0x3F) {
> >
> > undefined variable
> 
> I added variable names. Next patch will rename variables in the actual
> code once this is approved to match the ones in the comment.

patch ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

When you are offended at any man's fault, turn to yourself and study your
own failings. Then you will forget your anger. -- Epictetus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20081114/a73c1ffa/attachment.pgp>



More information about the ffmpeg-devel mailing list