[FFmpeg-devel] [PATCH] fix small memleak in rdt.c

Michael Niedermayer michaelni
Fri Nov 14 23:22:56 CET 2008


On Fri, Nov 14, 2008 at 02:04:00PM -0800, Baptiste Coudurier wrote:
> Michael Niedermayer wrote:
> > On Fri, Nov 14, 2008 at 03:17:26PM -0500, Ronald S. Bultje wrote:
> >> Hi,
> >>
> >> $subj.
> >>
> > 
> >> Sidenote: if url_open_buf() allocates, shouldn't url_close_buf() free
> >> it? That doesn't appear to be the case right now, hence my confusion
> >> when I originally implemented this... Maybe the API should be renamed
> >> or something? Or a comment in the API docs?
> > 
> > id say mark both as deprecated and put them under #if VERSION < X
> > close is unused, open is just used by ffserver.c
> 
> Humm :/
> Well is it possible then to rename init_put_byte, etc... to more decent
> names ?
> Like: av_alloc_byteio_context, av_init_byteio_context ?

isnt the existing av_alloc_put_byte() enough?

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No great genius has ever existed without some touch of madness. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20081114/44eebec8/attachment.pgp>



More information about the ffmpeg-devel mailing list