[FFmpeg-devel] [PATCH] RDT/Realmedia patches #2

Ronald S. Bultje rsbultje
Sun Nov 16 17:15:56 CET 2008


Hi,

On Sun, Nov 16, 2008 at 10:32 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Sat, Nov 15, 2008 at 03:51:17PM -0500, Ronald S. Bultje wrote:
>> @@ -175,10 +175,10 @@
>>
>>  int
>>  ff_rdt_parse_header(const uint8_t *buf, int len,
>> -                    int *set_id, int *seq_no, int *stream_id,
>> +                    int *pset_id, int *seq_no, int *pstream_id,
>>                      int *is_keyframe, uint32_t *timestamp)
>
> if you want to prefix pointers by p in a function, fine but i think
> it should be done consistently (within that function), that is for all pointer
> arguments. And in a seperate patch

Attached.

Ronald
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: rdt_parse_header-change_pointer.patch
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20081116/8a2c4cb0/attachment.txt>



More information about the ffmpeg-devel mailing list