[FFmpeg-devel] [PATCH] RDT/Realmedia patches #2

[Michael Niedermayer]

On Mon, Nov 17, 2008 at 09:40:34AM -0500, Ronald S. Bultje wrote:
> Hi again,
> 
> On Mon, Nov 17, 2008 at 9:37 AM, Ronald S. Bultje <rsbultje at gmail.com> wrote:
> > Attached is now a minor patch that modifies the type of one of the
> > structure components from uint32_t to int (the uint32_t is unneeded,
> > it's 16-bit max anyway).
> 
> And directly after that the patch that started this whole discussion,
> updated after all the previous work on this code. The patch uses the
> rule-, sorry, stream-parsing code in ff_rdt_parse_header() to find out
> which particular stream of the set this packet belongs to. So far, we
> only parsed the set number since we only download one stream per set,
> but with this patch, we can download (e.g. backup) all streams (e.g.
> all bitrates) from a server simultaneously. The subscribing to these
> streams isn't actually there yet, that comes in a next patch which
> I'll submit after this.
> 
> Ronald
[...]
> @@ -324,11 +325,12 @@
>      if (!s->parse_packet)
>          return -1;
>  
> -    if (!buf) {
> +    if (!buf && s->prev_stream_id != -1) {
>          /* return the next packets, if any */
>          timestamp= 0; ///< Should not be used if buf is NULL, but should be set to the timestamp of the packet returned....
>          rv= s->parse_packet(s->dynamic_protocol_context,
> -                            s->st, pkt, &timestamp, NULL, 0, flags);

> +                            s->ic->streams[s->st->index + s->prev_stream_id],

s->st has a poor name and lacks documentation


[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Dictatorship naturally arises out of democracy, and the most aggravated
form of tyranny and slavery out of the most extreme liberty. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20081117/4035a184/attachment.pgp>