[FFmpeg-devel] [PATCH] H.264 data tables cleanup

Jason Garrett-Glaser darkshikari
Thu Nov 20 09:29:50 CET 2008

On Thu, Nov 20, 2008 at 12:08 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Thu, Nov 20, 2008 at 12:49:03AM +0100, Diego Biurrun wrote:
>> So I've (re)started working on splitting off svq3.c from h264.c.
>> Here are some simple first steps:
>> - Remove unused tables from h264data.h.
> these tables are unused because we dont have an encoder ...
> putting them under appropriate ifdef or in a seperate encoder
> specific (not compiled) header seems better than removing them
> even if there are no plans for an encoder ...

What's the point though?  If someone wants them at some time in the
future, can't they just restore them from svn history?  Why keep
around code that has no plans to be used, even if ifdef'd out?

I notice this in h264.c as well (quant functions...)...

Dark Shikari

More information about the ffmpeg-devel mailing list