[FFmpeg-devel] [PATCH] H.264 data tables cleanup

[Diego Biurrun]

On Thu, Nov 20, 2008 at 09:08:17AM +0100, Michael Niedermayer wrote:
> On Thu, Nov 20, 2008 at 12:49:03AM +0100, Diego Biurrun wrote:
> > So I've (re)started working on splitting off svq3.c from h264.c.
> > 
> > Here are some simple first steps:
> > 
> > - Remove unused tables from h264data.h.
> 
> these tables are unused because we dont have an encoder ...
> putting them under appropriate ifdef or in a seperate encoder
> specific (not compiled) header seems better than removing them
> even if there are no plans for an encoder ...

I don't think it's a good idea to keep cruft around forever.  Also, we
are just talking about a handful lines of code.  Nobody will waste a
huge amount of time reimplementing them.

> > - Move a table that is only used there to svq3.c.
> 
> there is
> static const uint8_t slice_type_map[5]= {FF_P_TYPE, FF_B_TYPE, FF_I_TYPE, FF_SP_TYPE, FF_SI_TYPE};
> in h264.c

This is indeed a duplicate of golomb_to_pict_type.  So what do you want
done?

Diego