[FFmpeg-devel] Concerning RV40 chroma MC functions

Måns Rullgård mans
Tue Nov 25 18:57:57 CET 2008


Kostya wrote:
> On Tue, Nov 25, 2008 at 03:37:34PM +0100, Michael Niedermayer wrote:
>> On Tue, Nov 25, 2008 at 01:07:02PM +0200, Kostya wrote:
> [...]
>> > * should RV40 designers burn in hell?
>>
>> yes
>
> Another nicety - spot the fishy thing:
>
> gc_M_InterpolateChromaTable4
> 		dd offset M_MCCopyChroma4_H00V00 ;	DATA XREF: .got:0004DD70o
> 		dd offset M_MCCopyChroma4_H01V00
> 		dd offset M_MCCopyChroma4_H02V00
> 		dd offset M_MCCopyChroma4_H03V00
> 		dd offset M_MCCopyChroma4_H00V01
> 		dd offset M_MCCopyChroma4_H01V01
> 		dd offset M_MCCopyChroma4_H02V01
> 		dd offset M_MCCopyChroma4_H03V01
> 		dd offset M_MCCopyChroma4_H00V02
> 		dd offset M_MCCopyChroma4_H01V02
> 		dd offset M_MCCopyChroma4_H02V02
> 		dd offset M_MCCopyChroma4_H03V02
> 		dd offset M_MCCopyChroma4_H00V03
> 		dd offset M_MCCopyChroma4_H01V03
> 		dd offset M_MCCopyChroma4_H02V03
> 		dd offset M_MCCopyChroma4_H02V02
>
> (I assure you, the same thing occurs also for C function list and in another
> version of RV40 decoder).

LOL.  They probably made that mistake once, and now they can't correct it
without breaking compatibility.  Is the missing function defined somewhere?

-- 
M?ns Rullg?rd
mans at mansr.com




More information about the ffmpeg-devel mailing list