[FFmpeg-devel] [PATCH] RDT/Realmedia patches #2
Thu Nov 27 22:28:52 CET 2008
On Wed, Nov 26, 2008 at 09:41:52PM -0500, Ronald S. Bultje wrote:
> On Wed, Nov 26, 2008 at 6:40 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> > On Sun, Nov 23, 2008 at 11:16:19AM -0500, Ronald S. Bultje wrote:
> >> --- ffmpeg-svn.orig/libavformat/rdt.h 2008-11-18 20:24:07.000000000 -0500
> >> +++ ffmpeg-svn/libavformat/rdt.h 2008-11-23 09:52:23.000000000 -0500
> >> @@ -28,7 +28,7 @@
> >> typedef struct RDTDemuxContext RDTDemuxContext;
> >> -RDTDemuxContext *ff_rdt_parse_open(AVFormatContext *ic, AVStream *st,
> >> +RDTDemuxContext *ff_rdt_parse_open(AVFormatContext *ic, int first_stream_index,
> >> void *priv_data,
> >> RTPDynamicProtocolHandler *handler);
> > first?
> > first is 0, yes iam dumb :)
> > but seriously, i dont think its clear to the reader what first_stream_index
> > really is.
> "Stream" is the term you suggested. :-).
> > anyway IMHO the function needs some documentation anyway ...
> Will do... If you understand, with some imagination, what
> first_stream_index is, is the rest of the patch OK?
the patch is ok, the variable name first_stream_index is not
from the past mails i suspect it is supposed to be the first stream id
of the set this rdtdemux context is associated with.
But i am not sure if the average reader will guess this and iam not even
sure if the guess is correct.
One also has to consider that the reader may not know rdt at all ...
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Let us carefully observe those good qualities wherein our enemies excel us
and endeavor to excel them, by avoiding what is faulty, and imitating what
is excellent in them. -- Plutarch
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: Digital signature
More information about the ffmpeg-devel