[FFmpeg-devel] [PATCH] Simplify checks for particular GCC versions.

Diego Biurrun diego
Fri Oct 3 20:28:36 CEST 2008


On Fri, Oct 03, 2008 at 03:39:36PM +0200, Diego 'Flameeyes' Petten? wrote:
> Diego 'Flameeyes' Petten? <flameeyes at gmail.com> writes:
> 
> > +#if FF_GC_ATLEAST(3,3,0)
> 
> And of course this is wrong -_-; unfortunately I don't have an alpha
> here so it was out of my radar during the five make runs.
> 
> Should I resend?

Yes:

diego at cerebus:~/src/ffmpeg/ffmpeg$ patch --dry-run -p1 -i /tmp/gnuc.diff
patching file libavcodec/alpha/asm.h
Hunk #3 succeeded at 115 with fuzz 2.
patching file libavcodec/armv4l/mpegvideo_armv5te.c
patching file libavcodec/ppc/gcc_fixes.h
Hunk #1 FAILED at 24.
1 out of 2 hunks FAILED -- saving rejects to file libavcodec/ppc/gcc_fixes.h.rej
patching file libavutil/common.h
patching file libavutil/internal.h
patching file libavutil/mem.h

Otherwise the patch looks good to me, I will apply a fixed version
unless somebody speaks up against it.

Diego




More information about the ffmpeg-devel mailing list