[FFmpeg-devel] [PATCH] Use posix_memalign() instead of memalign()
Tue Oct 7 19:39:02 CEST 2008
On Tue, Oct 07, 2008 at 06:25:13PM +0100, M?ns Rullg?rd wrote:
> "Ramiro Polla" <ramiro.polla at gmail.com> writes:
> > On Tue, Oct 7, 2008 at 4:24 AM, M?ns Rullg?rd <mans at mansr.com> wrote:
> >> "Ramiro Polla" <ramiro.polla at gmail.com> writes:
> >>> Attached patch should spark some discussion...
> >>> --- libavutil/mem.c (revision 15575)
> >>> +++ libavutil/mem.c (working copy)
> >>> @@ -35,6 +35,10 @@
> >>> +#ifdef HAVE_POSIX_MEMALIGN
> >>> +#include <stdlib.h>
> >>> +#endif
> >> It is always save to #include <stdlib.h>
> > Now I see that the stdlib.h include comes from common.h.
> > And another thing, I remember there was some discussion regarding
> > whether we should include only the necessary files or whether it was
> > ok to just include common.h everywhere, but I forgot the outcome.
> I don't think there ever was a consensus.
I think the last definition you provided was pretty much consensus. You
should write something like it into the development guidelines.
Probably sending a patch first is a good idea.
More information about the ffmpeg-devel