[FFmpeg-devel] Realmedia patch

Ronald S. Bultje rsbultje
Mon Sep 1 00:36:04 CEST 2008


Hi Luca,

On Sat, Aug 30, 2008 at 11:27 AM, Luca Abeni <lucabe72 at email.it> wrote:
> Ronald S. Bultje wrote:
>> On Sat, Aug 30, 2008 at 6:30 AM, Luca Abeni <lucabe72 at email.it> wrote:
>>> Ronald S. Bultje wrote:
>>> [...]
>>>> @@ -918,7 +920,9 @@
>>>>              if (transport[0] != '\0')
>>>>                  av_strlcat(transport, ",", sizeof(transport));
>>>>              snprintf(transport + strlen(transport), sizeof(transport) - strlen(transport) - 1,
>>>> -                     "RTP/AVP/UDP;unicast;client_port=%d-%d",
>>>> +                     "%s;unicast;client_port=%d-%d",
>>> Is "client_port=%d-%d" really needed here, or would "client_port=%d"
>>> be enough? (RDT does not seem to have an RTCP-like companion protocol)
>>
>> UDP has one port per "m" stream
>
> This is exactly my point... UDP needs a port per stream, and here you are
> declaring two ports per stream (this makes sense for RTP, because it also
> needs port+1 for RTCP).

Attached is a slightly modified patch that only does %d for RDT.

Ronald
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: rtsp-setup.patch
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080831/ff2039c0/attachment.asc>



More information about the ffmpeg-devel mailing list