[FFmpeg-devel] [PATCH] split codec_id for ac-3 and e-ac-3

Justin Ruggles justin.ruggles
Mon Sep 1 16:34:56 CEST 2008


Michael Niedermayer wrote:
> On Sun, Aug 31, 2008 at 11:29:16PM -0400, Justin Ruggles wrote:
>> Ronald S. Bultje wrote:
>>> Hi Justin,
>>>
>>> On Sun, Aug 31, 2008 at 10:24 PM, Justin Ruggles
>>> <justin.ruggles at gmail.com> wrote:
>>>> Here is a patch to make a separate CODEC_ID_EAC3.  It adds a separate
>>>> demuxer, muxer, parser, and decoder for E-AC-3.
>>>>
>>>> After this is done, the various other muxers/demuxers can be modified to
>>>> treat E-AC-3 differently if needed.
>>> Index: libavcodec/ac3_parser.c
>>> ===================================================================
>>> --- libavcodec/ac3_parser.c	(revision 15137)
>>> +++ libavcodec/ac3_parser.c	(working copy)
>>> @@ -194,3 +194,11 @@
>>>      ff_aac_ac3_parse,
>>>      ff_parse_close,
>>>  };
>>> +
>>> +AVCodecParser eac3_parser = {
>>> +    { CODEC_ID_EAC3 },
>>> +    sizeof(AACAC3ParseContext),
>>> +    ac3_parse_init,
>>> +    ff_aac_ac3_parse,
>>> +    ff_parse_close,
>>> +};
>>>
>>> Can't you just add EAC3 in the array of ac3_parser? MP2/3 does that
>>> too, I think. No need for the separate entry.
>>>
>>> [...]
>> new patch attached which shares the parser.
> 
> ok

applied.

-Justin




More information about the ffmpeg-devel mailing list