[FFmpeg-devel] [PATCH] Fix Issue 616 : "flac on small file"

Justin Ruggles justin.ruggles
Wed Sep 3 01:53:07 CEST 2008


Justin Ruggles wrote:
> Jai Menon wrote:
>> Hi,
>>
>> On Tuesday 02 Sep 2008 10:59:49 pm Jai Menon wrote:
>>> Hi,
>>>
>>> Attached patch "fixes" issue 616. The default max_framesize is just too
>>> large.
> 
> I think this needs to be fixed in a different way.  There are other
> proposals out there which fix the problem.  They just haven't made it to
> SVN yet.  The main issue is that the metadata is sent to the decoder,
> which means that the buffer is not large enough for the header in some
> situations.  This has become more common since embedded image support
> was added to FLAC.

I see now that your patch does work better than the current behavior at
least.  It still doesn't solve the other related problem, but it fixes
the issue.  Ignore my rants. :)

-Justin





More information about the ffmpeg-devel mailing list