[FFmpeg-devel] [PATCH] MACE fixes

Vitor Sessak vitor1001
Sun Sep 7 01:16:29 CEST 2008


Hi,

Next in my cleanup list is libavcodec/mace.c. As it is now, its output 
differs from the binary decoder. Two patches:

mace1.diff: Do not share context variables between channels and don't 
zero them at decode_frame(). Before this patch, the decoded output could 
sound different of the binary decoder.

mace2.diff: Use the same weird S8 -> S16 conversion as quicktime. This 
should not sound really different, but makes much easier to verify 
conformity.

After these two patches, MACE3 files decode bit identical to the binary 
decoder and MACE6 files are pretty close.

BTW, is it ok if I clean it up without asking and be flamed in -cvslogs?

-Vitor
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mace1.diff
Type: text/x-diff
Size: 5425 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080907/a519126d/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mace2.diff
Type: text/x-diff
Size: 1304 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080907/a519126d/attachment-0001.diff>



More information about the ffmpeg-devel mailing list