[FFmpeg-devel] [PATCH] Fix g726 encoder

Michael Niedermayer michaelni
Fri Sep 12 15:37:58 CEST 2008


On Fri, Sep 12, 2008 at 01:41:28PM +0200, Rafa?l Carr? wrote:
> Benjamin Larsson wrote:
>> Rafa?l Carr? wrote:
>>> On Thu, 2008-09-04 at 12:51 +0200, Michael Niedermayer wrote:
>
>>>> I suspect this needs a update to the regression test checksums too
>>> Is that something you can do before commit, after applying the patch ?
>>>
>> After you have patched run "make test". This will show a diff in the
>> g726 regressions tests. Change the values so the reg tests doesn't fail.
>> And submit that with your patch.
>
> I attach the patch with regression tests diffs.
[...]
> -stddev: 8364.40 PSNR: 17.87 bytes:    96936/  1058444
[...]
> +stddev: 8557.39 PSNR: 17.67 bytes:    95788/  1058444

why does quality worsen by this "fix" ?

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Republics decline into democracies and democracies degenerate into
despotisms. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080912/aa07a98e/attachment.pgp>



More information about the ffmpeg-devel mailing list