[FFmpeg-devel] [PATCH] target svcd: fix setting default value of scan_offset option

Gert Vervoort gert.vervoort
Sat Sep 13 12:34:14 CEST 2008


Michael Niedermayer wrote:
> On Thu, Sep 11, 2008 at 10:11:39PM +0200, Gert Vervoort wrote:
>   
>> Hi,
>>
>> The attached patch fixes the "Unable to parse option value "SCAN_OFFSET": 
>> undefined constant or missing (" message when encoding for the svcd target.
>> [...]
>>     
>
>   
>> --- ffmpeg/ffmpeg.c.1	2008-09-11 21:39:28.000000000 +0200
>> +++ ffmpeg/ffmpeg.c	2008-09-11 21:41:27.000000000 +0200
>> @@ -3630,7 +3630,7 @@
>>          opt_default("maxrate", "2516000");
>>          opt_default("minrate", "0"); //1145000;
>>          opt_default("bufsize", "1835008"); //224*1024*8;
>> -        opt_default("flags", "+SCAN_OFFSET");
>> +        opt_default("scan_offset", "1");
>>     
>
> This change looks wrong
> the only bug i can see is that it is upper case.
>
>   
Indeed, I misunderstood the usage of flags. New patch attached.
Checked with vcdimager and the resulting MPEG stream does contain the 
user data for the scan offsets.

     Gert



-------------- next part --------------
A non-text attachment was scrubbed...
Name: svcd_scanoffset.diff
Type: text/x-diff
Size: 409 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080913/233f780a/attachment.diff>



More information about the ffmpeg-devel mailing list