[FFmpeg-devel] [PATCH] libx264: support for BUILD >= 63

Frans de Boer frans
Wed Sep 17 13:24:03 CEST 2008


On Wed, 2008-09-17 at 13:01 +0200, Dominik 'Rathann' Mierzejewski wrote:
> On Wednesday, 17 September 2008 at 12:29, M?ns Rullg?rd wrote:
> > 
> > Stefano Sabatini wrote:
> > > On date Tuesday 2008-09-16 23:52:50 +0100, M?ns Rullg?rd encoded:
> > >> Stefano Sabatini <stefano.sabatini-lala at poste.it> writes:
> > >>
> > >> > On date Tuesday 2008-09-16 11:28:56 +0200, Stefano Sabatini encoded:
> > >> >> On date Tuesday 2008-09-16 09:24:40 +0100, M?ns Rullg?rd encoded:
> > >> >> > Stefano Sabatini <stefano.sabatini-lala at poste.it> writes:
> > >> > [...]
> > >> >> > It's always been expected that uses should have a recent version of
> > >> >> > libraries they build FFmpeg against.  Testing every little thing would
> > >> >> > become such a chore.
> > >> >>
> > >> >> We know which version we need, and a simple check in the configure
> > >> >> should ensure that the user is compiling against it.
> > >> >>
> > >> >> > > And while we're at it we could assert(X264_BUILD == x264_build()) in
> > >> >> > > the init code (assuming that function is implemented).
> > >> >> >
> > >> >> > It a little harsh with assert(), wouldn't you say?  In fact, this
> > >> >> > shouldn't be needed at all, assuming libx264 uses correct shared
> > >> >> > library versioning.
> > >> >>
> > >> >> See my other mail in response to Dark Shikari, but I have not a strong
> > >> >> opinion on this, the configure check may be sufficient.
> > >> >
> > >> > Attached there is a first experiment with check_version.
> > > [...]
> > >> Rejected.  It doesn't work if cross-compiling.  It may have other
> > >> faults too; I didn't check carefully.  Besides, I don't think this
> > >> check is necessary.
> > >
> > > Would be a solution using pkg-config acceptable?
> > 
> > No.  pkg-config only leads to misery.  Did you know that every time
> > someone uses pkg-config, a child in Africa dies?
> 
> Don't be ridiculous. I'm sure a solution using pkg-config with a fallback
> to some other method if pkg-config is not available is acceptable.
> 
> Regards,
> R.
> 
I concur, pkg-config is a solution used with many other packages. In
fact, pkg-config is mostly a prerequisite for a proper configuration
process and doing it any other way requires taking into account the many
different distributions with their own directory structure, which
happens to change sometimes too.

Regards,
Frans.






More information about the ffmpeg-devel mailing list