[FFmpeg-devel] Realmedia patch

Ronald S. Bultje rsbultje
Wed Sep 17 23:47:47 CEST 2008


Hi Luca,

On Wed, Sep 17, 2008 at 5:41 PM, Luca Abeni <lucabe72 at email.it> wrote:
> Ronald S. Bultje wrote:
>> On Wed, Sep 17, 2008 at 5:11 PM, Luca Abeni <lucabe72 at email.it> wrote:
>>> Ronald S. Bultje wrote:
>>>  > @@ -1323,6 +1338,7 @@
>>>  >          for (i = 0; i < rt->nb_rtsp_streams; i++) {
>>>  >              if (i != 0) av_strlcat(cmd, ",", sizeof(cmd));
>>>  >              ff_rdt_subscribe_rule(cmd, sizeof(cmd), i, 0);
>>>  > +            if (rt->transport == RTSP_TRANSPORT_RDT)
>>>  >              ff_rdt_subscribe_rule2(
>>>  >                  rt->rtsp_streams[i]->rtp_ctx,
>>>  >                  cmd, sizeof(cmd), i, 0);
>>>
>>> Why is only ff_rdt_subscribe_rule2() under the "RTSP_TRANSPORT_RDT" case?
>>> Isn't ff_rdt_subscribe_rule() RDT specific too? (otherwise, "ff_rdt_" is
>>> misleading).
>>
>> I'll rename it ff_real_() in the end. Do you want that before or after
>> all other patches? (My plan was after.)
>
> I think you can do it after. I was just surprised by the position of the
> "if()", but if this is intended I have no problems with it.

It's intended. It's basically selection of the substream in RDT
(loading of the correct OpaqueData). The rest (actual subscription) is
in the whole function, which is already under if (server == REAL). So
yes, it's intended. I'll commit in 2-3 days as normal.

Thanks again,
Ronald




More information about the ffmpeg-devel mailing list