[FFmpeg-devel] [PATCH] Implement version check in configure

Stefano Sabatini stefano.sabatini-lala
Fri Sep 19 00:23:52 CEST 2008


On date Wednesday 2008-09-17 23:03:24 +0100, M?ns Rullg?rd encoded:
> Aurelien Jacobs <aurel at gnuage.org> writes:
[...]
> > If we have a clean fallback to some other method, we don't need the
> > pkg-config method anymore...
> 
> Quite.
> 
> >> The only alternative I can see for detecting the header version is to
> >> grep the 264.h header, which leads to a very ad-hoc solution, or not
> >> to support the version check at all, [...]
> >
> > Maybe something as simple as doing a check_cpp on the following code:
> >
> > #include <x264.h>
> > #if X264_BUILD < 63
> > #error "outdated x264"
> > #endif
> >
> > IIRC, #error is not standard, but I guess any compiler which don't
> > support it will just error out because of the unknown token, and
> > thus, will also have the desired effect in this specific case.
> 
> #error is C99.

I'm perfectly fine with this approach, is less powerful than that
supported by pkg-config but it should work on most cases.

If this is OK I'll apply the patch in two distinct steps
(check_version and require3 + check on the libx264 version, then I
suggest to apply that check to other libraries as well).

Regards.
-- 
FFmpeg = Friendly Frightening MultiPurpose Everlasting Game
-------------- next part --------------
A non-text attachment was scrubbed...
Name: check-version-01.patch
Type: text/x-diff
Size: 1685 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080919/548d9020/attachment.patch>



More information about the ffmpeg-devel mailing list