[FFmpeg-devel] [PATCH] arm-wince-cegcc build
Tue Sep 23 11:58:32 CEST 2008
Eric Bellotti wrote:
> This patch enables SVN head to build out of the box with the
> arm-wince-cegcc toolchain. Builds targetting ce should define the
> UNDER_CE macro else things like fd_set are multiply defined.
I believe you (it's wince after all), but could you please explain
the documented effect of defining this macro (or point at some docs)?
> problem is in the asm files with the function keyword such as: ".type
> ff_simple_idct_add_armv6, %function". arm-wince-cegcc-as cannot process
> it. Wrapped these in #ifdefs.
The patch is unacceptable in its current form. The configure bit should
be done similarly to other OS-specific things. The assembler keywords
can be dropped entirely (they're not strictly necessary), or they could
be replaced with a macro. #ifdef on each one is not acceptable.
mans at mansr.com
More information about the ffmpeg-devel