[FFmpeg-devel] [Patch] fix mingw/faac linking

Dion Galbreath DionG
Thu Sep 25 22:51:44 CEST 2008


-----Original Message-----
From: ffmpeg-devel-bounces at mplayerhq.hu [mailto:ffmpeg-devel-bounces at mplayerhq.hu] On Behalf Of Dion Galbreath
Sent: Thursday, September 25, 2008 3:41 PM
To: FFmpeg development discussions and patches
Subject: Re: [FFmpeg-devel] [Patch] fix mingw/faac linking


-----Original Message-----
From: ffmpeg-devel-bounces at mplayerhq.hu [mailto:ffmpeg-devel-bounces at mplayerhq.hu] On Behalf Of Ramiro Polla
Sent: Thursday, September 25, 2008 3:32 PM
To: FFmpeg development discussions and patches
Subject: Re: [FFmpeg-devel] [Patch] fix mingw/faac linking

On Thu, Sep 25, 2008 at 4:30 PM, Andrew Voznytsa
<andrew.voznytsa at gmail.com> wrote:
> On Thu, Sep 25, 2008 at 9:38 PM, M?ns Rullg?rd <mans at mansr.com> wrote:
>
>>  "Andrew Voznytsa" <andrew.voznytsa at gmail.com> writes:
>>
>> > Oops - patch attached. Sorry.
>> >
>> > Thanks,
>> >
>> > Andrew
>> >
>> >
>> > Index: libavcodec/libfaac.c
>> > ===================================================================
>> > --- libavcodec/libfaac.c      (revision 15413)
>> > +++ libavcodec/libfaac.c      (working copy)
>> > @@ -25,6 +25,11 @@
>> >   */
>> >
>> >  #include "avcodec.h"
>> > +
>> > +#ifdef __MINGW32__
>> > +#define WIN32
>> > +#endif
>> > +
>> Rejected.
> Reason?

#ifdef'ing a specific system is not a good idea, since the system
might change at some other point in time, and FFmpeg minimizes the use
of such ifdefs.

Besides, I never got any problem with libfaac failing to link. What
version are you using? Is it compiled with mingw as well?

Ramiro Polla

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel at mplayerhq.hu
https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel



read ffmpeg-user and or libav-users there are a few people complaining.  I am using mingw32-gcc-4.2.1
and it errs. I posted on one of those above news groups how to edit the h files for mingw users so they can get past the problems. There is with x264, and aac. But unfortunately mingw compilations get broken all the time.  Who's the maintainer so we can whip em into shape ;)

:)  

Dion


Here to be exact

http://lists.mplayerhq.hu/pipermail/ffmpeg-user/2008-August/017007.html
http://lists.mplayerhq.hu/pipermail/ffmpeg-user/2008-August/017008.html


what is the preferred compiler to use cygwin or however you spell it? Or something else??

Seems mingw doesn't get any love. Been a month and there still broken for mingw :)


_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel at mplayerhq.hu
https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel




More information about the ffmpeg-devel mailing list