[FFmpeg-devel] [PATCH] Print AV_NOPTS_VALUE in seek test

Michael Niedermayer michaelni
Fri Sep 26 14:26:05 CEST 2008


On Tue, May 06, 2008 at 12:05:52AM +0100, Ramiro Polla wrote:
> Michael Niedermayer wrote:
> > On Mon, May 05, 2008 at 05:35:37PM +0100, Ramiro Polla wrote:
> >> Hello,
> >>
> >> Ramiro Polla wrote:
> >>> Michael Niedermayer wrote:
> >>>> On Thu, May 01, 2008 at 09:28:37PM +0100, Ramiro Polla wrote:
> >>>>> Hello,
> >>>>>
> >>>>> Attached patch makes seek_test print AV_NOPTS_VALUE instead of some big 
> >>>>> negative and apparently meaningless number.
> >>>> Complicating the code for no apparent reason, the regression tests are
> >>>> just for developers knowing what they do. And someone not knowing what
> >>>> the big meaningless number is wont be able to make any sense of
> >>>> "AV_NOPTS_VALUE" either.
> >>> Seek test fail on MinGW because MSVCRT doesn't properly printf() big 
> >>> numbers. Instead of printing
> >>> pts:-102481911520608.625000
> >>> it prints
> >>> pts:-102481911520608.600000
> >> Could you please reconsider this?
> >> Seek tests with latest MinGW CVS only fail because of this printf. The 
> >> tests don't really fail, but the way the results are printed do. This can 
> >> easily be avoided in FFmpeg's side by writing cleaner output.
> > 
> > Well if you really insist then try
> > #define ts2float(ts) ((ts) == AV_NOPTS_VALUE ? 0.0/0.0 : ts)
> 
> MSVCRT prints "-1.INF00" or something like that, which is much different 
> than the POSIX "nan". Anyways POSIX allows other stuff to print out 
> instead of "nan", so it wouldn't even be compatible in all 
> POSIX-compliant systems. 

> I'll try to think of some other way.

ping?

you could use:
printts(int64_t ts, double base){
    if(ts==AV_NOPTS_VALUE) printf("?");
    else                   printf("%f", ts*base);
}

also when  you use above, make sure both use the same amount of space so the
result is nicely aligned

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many that live deserve death. And some that die deserve life. Can you give
it to them? Then do not be too eager to deal out death in judgement. For
even the very wise cannot see all ends. -- Gandalf
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080926/55f69142/attachment.pgp>



More information about the ffmpeg-devel mailing list