[FFmpeg-devel] [PATCH 1/4] Uniformly define _XOPEN_SOURCE to 600.

Diego Biurrun diego
Mon Sep 29 08:22:43 CEST 2008


On Sun, Sep 28, 2008 at 05:18:47PM +0200, Michael Niedermayer wrote:
> On Sun, Sep 28, 2008 at 02:22:15PM +0100, M?ns Rullg?rd wrote:
> > Diego 'Flameeyes' Petten? <flameeyes at gmail.com> writes:
> > 
> > > Some source files define _XOPEN_SOURCE to have access to extended
> > > functions like gethostname() or mkstemp(); some files define it to
> > > 500, others to 600.
> > >
> > > The feature_tests.h header from Sun systems (Solaris/OpenSolaris) will
> > > abort the build if _XOPEN_SOURCE is defined to 500, and C99 is
> > > requested (as well as POSIX.1-2001), and will only accept it to be
> > > defined to 600.
> > >
> > > Instead of leaving it up to the source files to define _XOPEN_SOURCE,
> > > require it together with POSIX.1-2001 in the compilation flags, so
> > > that it's uniformly enabled.
> > 
> > I already suggested that, but Michael wanted to keep the enabled stuff
> > to a minimum, in order to avoid accidentally depending on something
> > not strictly needed.
> > 
> > That said, the only value of _XOPEN_SOURCE mentioned by the standard
> > is 600.  Setting it to 500 (or any other value) has no defined effect.
> > As such, I suggest that we change the value to 600 in the files that
> > define it.
> 
> no objections

Implemented.

Diego




More information about the ffmpeg-devel mailing list