[FFmpeg-devel] [PATCH] Description of avcodec_encode_audio()

Michael Niedermayer michaelni
Wed Apr 1 19:17:42 CEST 2009

On Wed, Apr 01, 2009 at 05:01:58PM +0100, John Fletcher wrote:
> Hi,
> I attach a patch for libavcodec/avcodec.h to correct the
> description of the function avcodec_encode_audio()
> There is a note that the output buffer should be at least
> FF_MIN_BUFFER_SIZE bytes large but this would mess things
> up for PCM and in fact the limit is no longer applied.

patch rejected, the buffer MUST be FF_MIN_BUFFER_SIZE bytes large
and "is no longer applied" is incorrect it was never applied, the user
can if he either knows by some means that the buffer will be large enough
or works in a secure environment where the input is known not to contain
an exploit use a smaller buffer and deal with the segfaults somehow
The PCM case falls in the category where the user might know how much
space will be needed

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The misfortune of the wise is better than the prosperity of the fool.
-- Epicurus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090401/7773808e/attachment.pgp>

More information about the ffmpeg-devel mailing list