[FFmpeg-devel] Google Summer of Code participation
Wed Apr 1 21:56:33 CEST 2009
On Wed, Apr 01, 2009 at 08:16:45PM +0200, Thilo Borgmann wrote:
> Michael Niedermayer schrieb:
>> as ronald said, AVPacket can be moved to avcodec.h
>> I think simply updating all AVCodecs should do.
>> It would break applications that have their own private AVCodecs but these
>> should be few and they are evil anyway because where they not they would
>> have submitted their AVCodec to us.
>> (i guess someone will in 5min explain a non evil reason why one would have
>> ones own AVCodec ...)
>> and to be honest i prefer bumping the major version than having anyone
>> spend a lot of time comming up with some complex woraround. That is if
>> theres no easy way to avoid it and simply changing AVCodec doesnt work
>> breaks more than a obscure application.
> I've altered the AVCodec struct to contain a decode function pointer
> parameterized by a pointer to an AVPacket struct.
> I've already integrated the necessary update to the audio/video decoder
> related to the CorePNG testfile (pngdec.c & pcm.c). This comes as a new
> function avcodec_decode_frame2() which takes an AVPacket. It is a simple
> wrapper calling the original accodec_decode_frame() by now. The new
> function is then specified in the AVCodec struct.
> For the pcm.c there were some prefix addons for the functions, so it seems
> not to be as generic as I thought it would be. Also, the content of the
> AVCodec struct was #define'd.
> Fortunately, I can compile without touching the other codecs (of course, a
> call to them will cause a segmentation fault). So, this update already
> works for the CorePNG testfile.
> The question is, if this approach is ok and, if so, if someone feels
> appointed to integrate the wrapper function to the other codecs. I can do
> but as time is running out for my qualification task I would like to start
> off with the real decoding task.
if updating all codecs is too much work, adding a new function ptr to AVCodec
and simply checking which is != NULL should allow adding this without updating
(sorry it was to late yesterday for my brain to work and see this as obvious
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
If you think the mosad wants you dead since a long time then you are either
wrong or dead since a long time.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: Digital signature
More information about the ffmpeg-devel