[FFmpeg-devel] Google Summer of Code participation

Vitor Sessak vitor1001
Wed Apr 1 22:38:19 CEST 2009

Thilo Borgmann wrote:
> Ok here is a patch which shows my proposals. Remark: This is not meant 
> to be applied, just reviewed... so no need to point at the wrong indents 
> at some places and such....

I understand your idea, but one of the reasons with nitpick so much 
about indentation is that it makes it hard to review a patch. For 
example, this chunk:

> Index: libavcodec/pngdec.c
> ===================================================================
> --- libavcodec/pngdec.c	(Revision 18211)
> +++ libavcodec/pngdec.c	(Arbeitskopie)
> @@ -486,8 +486,8 @@
>                      av_log(avctx, AV_LOG_ERROR, "get_buffer() failed\n");
>                      goto fail;
>                  }
> -                p->pict_type= FF_I_TYPE;
> -                p->key_frame= 1;
> +				p->pict_type= FF_I_TYPE;
> +				p->key_frame= 1;

It doesn't really change anything, but the reviewer need to double-check 
if there isn't anything that have really changed. In the changes in 
libavcodec/utils.c in particular, the mixing of indentation and 
functional changes makes it hard to read.


More information about the ffmpeg-devel mailing list