[FFmpeg-devel] [PATCH][VAAPI][5/6] Add VC-1 bitstream decoding (take 8)

Gwenole Beauchesne gbeauchesne
Thu Apr 2 17:06:57 CEST 2009


On Thu, 2 Apr 2009, Benjamin Larsson wrote:

>>>>>>> New patch attached. Also made sure B/BI-types were correctly checked 
>>>>>>> for.
>>>>>>> 
>>>>>> looks ok but you may also need to get an approval from Michael since 
>>>>>> this
>>>>>> is a new file and not the stuff maintained by me
>>>>>> 
>>>>> Ping. Here is the same patch minus some assert()'s.
>>>>> 
>>>> Ping. Here is the same (functionally) patch minus single line functions 
>>>> and some vertical alignment "compression".
>>>> 
>>> Ping. Here is a new patch to cope with new VA API buffers allocation logic 
>>> and a cosmetics change (use a temp var to retrieve the MpegEncContext in a 
>>> cast-less way).
>>> 
>>> Michael? Kostya already approved the initial patch:
>>> 
>> 
>> i leave this review entirely to kostya
>> 
>> [...]
>
> Just a note, I think this review will take a little bit of time. Be patient.

What do you mean? Kostya already approved the patch but suggested to wait 
for Michael's advice.
<https://lists.mplayerhq.hu/pipermail/ffmpeg-devel/2009-March/066060.html>

Anyway, for your convenience, I have attached a diff -ub between the 
approved patch rev 5 and the rev 8 I sent earlier today. As you can see, 
this is only minor cosmetics.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ffmpeg.hwaccel.vaapi.vc1.5.to.8.diff
Type: text/x-diff
Size: 8805 bytes
Desc: 
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090402/4593ba55/attachment.diff>



More information about the ffmpeg-devel mailing list