[FFmpeg-devel] [PATCH] vobsub in mov support

Baptiste Coudurier baptiste.coudurier
Thu Apr 2 20:26:34 CEST 2009

Reimar D?ffinger wrote:
> On Thu, Apr 02, 2009 at 10:46:13AM -0700, Baptiste Coudurier wrote:
>>> The code basically looks like this now:
>>> search audio id
>>> if (!is VIDEO && id found)
>>>   is AUDIO
>>> else if (!is AUDIO) {
>>>   search video id
>>>   if (id found) is VIDEO
>>>   else if (is DATA) {
>>>     search sub id
>>>     if (id found) is SUB
>>>   }
>>> }
>>> While IMHO what was _meant_ is
>>> if (is AUDIO or is DATA) {
>>>   search audio id
>>>   if (id found) is AUDIO
>>> }
>>> if (is VIDEO or is DATA) {
>>>   search video id
>>>   if (id found) is VIDEO
>>> }
>> This does not work because "raw " is used both in video and audio.
>> In this case handler has precedence.
> Huh? If a handler is given, the codec_type will be set accordingly.

Yes and my point was that is might not be set if handler is after "stsd"
and this happens that's why codec type is set here.

> My example pseudo-code will _only_ override a CODEC_TYPE_DATA

Yes and that will override to CODEC_TYPE_AUDIO the fourcc "raw " which
is possibly video, but we do not this only if the handler has been parsed.


Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
checking for life_signs in -lkenny... no
FFmpeg maintainer                                  http://www.ffmpeg.org

More information about the ffmpeg-devel mailing list