[FFmpeg-devel] [PATCH] libavfilter-soc: sws cpu caps flags detection

[Stefano Sabatini]

On date Thursday 2009-04-02 23:06:22 +0200, Michael Niedermayer encoded:
> On Thu, Apr 02, 2009 at 10:49:18PM +0200, Stefano Sabatini wrote:
> > On date Wednesday 2009-04-01 22:40:21 +0200, Michael Niedermayer encoded:
> > > On Wed, Apr 01, 2009 at 09:47:10PM +0200, Stefano Sabatini wrote:
> > > > Hi all,
> > > > 
> > > > as in subject.
> > > > 
> > > > BTW SWS_CPU_CAPS_MMX2 and SWS_CPU_CAPS_BFIN are not used, since I
> > > > don't know how to map them to corresponding FF_MM_* flags.
> > > 
> > > FF_MM_MMXEXT
> > 
> > Updated, I also suggest to rename SWS_CPU_CAPS_MMX2 ->
> > SWS_CPU_CAPS_MMXEXT for consistency with lavc 
> 
> > (or the other way if you
> > prefer).
> 
> i do and the cpu caps should be merged so they match with the next major bump
> and dont need this remappingf anymore

Thus I suggest to move them to lavu, maybe togheter with all the CPU
detection stuff.

> [...]
> > @@ -66,6 +77,11 @@
> >          }
> >      }
> >  
> > +    {
> > +        int sws_flags = av_get_int(scale->sws, "sws_flags", NULL);
> > +        av_set_int(scale->sws, "sws_flags", sws_flags + get_sws_cpu_caps_flags());
> > +    }
> > +
> >      /* sanity check parms */
> >      if(scale->w <  -1 || scale->h <  -1)
> >          return -1;
> 
> can the user still override it ?

No, maybe it's better to make the user *request* for the filter to set
them. Feel free to suggest a better name for the option, also the
options parsing should be addressed in a more robust/safer way (but
then I'm starting to feel like lavfi won't never be integrated :-().

Regards.
-- 
FFmpeg = Free and Fierce Most Pitiless Elegant God
-------------- next part --------------
A non-text attachment was scrubbed...
Name: define-mm-mmx2.patch
Type: text/x-diff
Size: 956 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090403/755460c4/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: scale-support-cpuflags.patch
Type: text/x-diff
Size: 1420 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090403/755460c4/attachment-0001.patch>