[FFmpeg-devel] [PATCH] libavfilter-soc: sws cpu caps flags detection

Michael Niedermayer michaelni
Sat Apr 4 04:29:28 CEST 2009


On Sat, Apr 04, 2009 at 12:40:24AM +0200, Stefano Sabatini wrote:
> On date Friday 2009-04-03 02:14:03 +0200, Michael Niedermayer encoded:
> > On Fri, Apr 03, 2009 at 01:27:32AM +0200, Stefano Sabatini wrote:
> > > On date Friday 2009-04-03 00:22:12 +0200, Michael Niedermayer encoded:
> > > > On Fri, Apr 03, 2009 at 12:06:05AM +0200, Stefano Sabatini wrote:
> > > [...]
> > > > > > i do and the cpu caps should be merged so they match with the next major bump
> > > > > > and dont need this remappingf anymore
> > > > > 
> > > > > Thus I suggest to move them to lavu, maybe togheter with all the CPU
> > > > > detection stuff.
> > > > 
> > > > lavu is supposed to be a small lightweight lib that contains ONLY
> > > > things that are usefull for a wide range of applications.
> > > > 
> > > > Every time someone suggests to move something into lavu without ANY
> > > > argument that honestly feels like a punch to the face.
> > > 
> > > Maybe I'm wrong but my idea was:
> > > lavc depends on lavu and on lsws
> > 
> > lavc should not depend on lsws
> > 
> > 
> > > lsws depends on lavu
> > > 
> > > so we have to put that thingy either in lavu or in lsws, I believe
> > > lavu is a more suitable place.
> > > 
> > > Also I don't think that:
> > > * cpu detection is so much code
> > 
> > > * cpu detection is not useful to a wide range of applications
> > 
> > where you trying to say this without the "not" ?
> 
> I wanted to say:
> "cpu detection *may* be useful to many applications"
> 
> but then I'm no maintainer and I trust your decisions, but I don't
> know where such thing should be placed since lavc shouldn't depend on
> lsws and I think that lsws doesn't depend on lavc, so I don't know how
> they could share it if not in lavu.
> 
> Sorry if I'm missing (again) something trivial.

the trivial thing is that i like to hear arguments for moving things to
lavu, you now provided one. Still its a *may*, if some application
author would say he would want & use it from lavu that would be a better
argument.

and about sws needing cpu detection, it doesnt, the user app can set the
cpu flags, all user apps that care about speed will already have sone kind
of cpu capability flags ...

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Observe your enemies, for they first find out your faults. -- Antisthenes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090404/a384da06/attachment.pgp>



More information about the ffmpeg-devel mailing list