[FFmpeg-devel] Google Summer of Code participation
Tue Apr 7 22:54:52 CEST 2009
Michael Niedermayer schrieb:
> they break vp6 decoding
I think we are talking about revision 8?
The vp6 decoder defines vp56_decode_frame as their decoding function,
which looks good in the source file and compiles fine. I do not see
anything wrong about vp56 or vp6 in the output of make test.
What exactly does not work?
>> diff --git a/ffmpeg.c b/ffmpeg.c
>> index cb15120..a35f282 100644
>> --- a/ffmpeg.c
>> +++ b/ffmpeg.c
>> @@ -1224,8 +1224,8 @@ static int output_packet(AVInputStream *ist, int ist_index,
>> data_size= samples_size;
>> /* XXX: could avoid copy if PCM 16 bits with same
>> endianness as CPU */
>> - ret = avcodec_decode_audio2(ist->st->codec, samples, &data_size,
>> - ptr, len);
>> + ret = avcodec_decode_audio3(ist->st->codec, samples, &data_size,
>> + pkt);
>> if (ret < 0)
>> goto fail_decode;
>> ptr += ret;
> this looks wrong
Hmm. It compiles and works fine here.
What exactly is looking wrong? In context to the broken vp6 decoding?
More information about the ffmpeg-devel