[FFmpeg-devel] [PATCH] fix H.264 crash (issue 706)

Reimar Döffinger Reimar.Doeffinger
Thu Apr 9 23:31:46 CEST 2009

On Thu, Apr 09, 2009 at 10:42:37PM +0200, Michael Niedermayer wrote:
> On Thu, Apr 09, 2009 at 10:33:49PM +0200, Reimar D?ffinger wrote:
> > Well, but that code will only run if there is either either a DC or a MV
> > error (see above), whereas the problematic code will only run if there
> > is no MV error. So if there is only an AC error I think the code I added
> > above would be necessary I think...
> short awnser
> our h264 decoder doesnt set AC_ERROR without MV_ERROR

But that code is not used only by H.264...
Also, I sure don't think at all that more undocumented, obscure, not
generally-correct and inconsistenly applied assumptions is really what
any of the MPEG-related code needs.

> the code is called "/* set unknown mb-type to most likely */"

Well, _that_ one is easily fixed.
Note that attached patch is completely untested right now.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: issue706_4.diff
Type: text/x-diff
Size: 3452 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090409/d818bee6/attachment.diff>

More information about the ffmpeg-devel mailing list