[FFmpeg-devel] [PATCH] use NULL instead of av_destruct_packet_nofree

Michael Niedermayer michaelni
Sat Apr 11 14:33:11 CEST 2009

On Sat, Apr 11, 2009 at 11:09:01AM +0200, Reimar D?ffinger wrote:
> Hello,
> this should resolve issues caused by non-working function pointer
> comparisons on MinGW.
> The checks still stay there to maintain API/ABI compatibility.
> There is still a ABI issue, since binaries compiled against older
> header versions but using newer libs will not set pkt->data or
> pkt->size to 0 anymore during destruct for the default "nofree"
> packets.
> There is still a pkt->destruct == av_destruct_packet in
> libavformat/utils.c, but I think this will only lead to worse
> performance and thus can be ignored (though I still think
> it is an ugly optimization hack, it may well be possible to
> share packets with pkt->destruct != av_destruct_packet
> without fully duplicating them).
> In addition I am also a bit irritated as to why libavformat/utils.c
> set pkt->duration and pkt->destruct, those should have been set
> like this already during init_packet.

patch ok

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I do not agree with what you have to say, but I'll defend to the death your
right to say it. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090411/28e2b5ab/attachment.pgp>

More information about the ffmpeg-devel mailing list