[FFmpeg-devel] [PATCH] Document ff_put_string()

[Michael Niedermayer]

On Sat, Apr 11, 2009 at 03:10:28PM +0200, Stefano Sabatini wrote:
> On date Saturday 2009-04-11 13:27:32 +0200, Michael Niedermayer encoded:
> > On Sat, Apr 11, 2009 at 10:42:15AM +0200, Stefano Sabatini wrote:
> [...]
> > > Second try attached.
> > > 
> > > Regards.
> > > -- 
> > > FFmpeg = Frenzy and Foolish Mysterious Pitiless Entertaining Game
> > 
> > > Index: ffmpeg/libavcodec/bitstream.h
> > > ===================================================================
> > > --- ffmpeg.orig/libavcodec/bitstream.h	2009-04-11 10:21:03.000000000 +0200
> > > +++ ffmpeg/libavcodec/bitstream.h	2009-04-11 10:40:20.000000000 +0200
> > > @@ -159,6 +159,13 @@
> > >   * Pads the bitstream with zeros up to the next byte boundary.
> > >   */
> > >  void align_put_bits(PutBitContext *s);
> > > +
> > > +/**
> > > + * Puts the string \p s in the bitstream.
> > > + *
> > 
> > > + * @param put_zero if non-zero [...]
> > 
> > still same issue
> 
> So I suppose the problem is "non-zero". Check again (also please be
> more explicit the next time).

the problem is that you repeat the word zero while one refers to the value
of a parameter and one to the name of the parameter, you still do that

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

GMX, the mailprovider that uses RBL lists to reject mails from your friends
running their own mailserver at home. The mailprovider that obscures the
origin of mails (mis)identified as viruses. The mailprovider that improves
security my disallowing more secure forms of authentication.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090411/59c04159/attachment.pgp>