[FFmpeg-devel] Proposal: x264_version() function?

[Reimar Döffinger]

On Sat, Apr 11, 2009 at 02:17:36PM +0000, Loren Merritt wrote:
> @@ -413,7 +413,8 @@ int x264_nal_encode( void *, int *, int b_annexeb, x264_nal_t *nal );
>  
>  /* x264_encoder_open:
>   *      create a new encoder handler, all parameters from x264_param_t are copied */
> -x264_t *x264_encoder_open   ( x264_param_t * );
> +#define x264_encoder_open( param ) x264_encoder_open_internal( param, X264_BUILD )
> +x264_t *x264_encoder_open_internal( x264_param_t *, int api_version );

Well, it may be a good idea, but it definitely is application-visible,
e.g. if an application tries to get a function pointer for
x264_encoder_open , in particular any application that wants to use
dlopen...
You could of course leave the x264_encoder_open function in there as-is,
but that would still cause weird difference between linked and dlopened
libx264...