[FFmpeg-devel] [PATCH] Description of avcodec_encode_audio()
Sat Apr 11 23:15:26 CEST 2009
On date Friday 2009-04-03 18:49:39 +0200, Michael Niedermayer encoded:
> On Thu, Apr 02, 2009 at 11:33:43AM +0100, John Fletcher wrote:
> > > patch rejected, the buffer MUST be FF_MIN_BUFFER_SIZE bytes large
> > > and "is no longer applied" is incorrect it was never applied, the user
> > > can if he either knows by some means that the buffer will be
> > > large enough
> > > or works in a secure environment where the input is known not
> > > to contain
> > > an exploit use a smaller buffer and deal with the segfaults somehow
> > > The PCM case falls in the category where the user might know how much
> > > space will be needed
> > OK, here is a revised patch.
> > I was misled by this comment so I think further explanation
> > is helpful.
> > When encoding a video frame's worth of audio samples to PCM,
> > you typically need to set buf_size to a value lower than
> > FF_MIN_BUFFER_SIZE.
> patch ok
Applied. Thanks John for taking the time to post and discuss it.
FFmpeg = Freak Foolish Mortal Power Evangelical Gangster
More information about the ffmpeg-devel